Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated i18next-xhr-backend with i18next-http-backend #461

Merged
merged 1 commit into from
May 31, 2024
Merged

Replace deprecated i18next-xhr-backend with i18next-http-backend #461

merged 1 commit into from
May 31, 2024
+62 −11

Conversation

ziegenberg
Copy link
Member

The new i18next-http-backend is based on the deprecated i18next-xhr-backend and can mostly be used as a drop-in replacement.

@ziegenberg ziegenberg added the type:dependencies Pull requests that update a dependency file label May 24, 2024
@ziegenberg ziegenberg force-pushed the replace-deprecated-i18next-xhr-backend branch from a06a915 to 90b11bd Compare May 29, 2024 11:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 29, 2024 •
edited
Loading

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-461

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-461

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@ziegenberg ziegenberg force-pushed the replace-deprecated-i18next-xhr-backend branch from 90b11bd to fbc9864 Compare May 31, 2024 13:12
@github-actions GitHub Actions
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/461/2024-05-31_13-12-13/ .
It might take a few minutes for it to become available.

@ziegenberg ziegenberg force-pushed the replace-deprecated-i18next-xhr-backend branch from fbc9864 to 8df5fcd Compare May 31, 2024 13:34
@ziegenberg
Copy link
Member Author

Rebased onto current main

@github-actions GitHub Actions
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/461/2024-05-31_13-34-41/ .
It might take a few minutes for it to become available.

@lkiesow lkiesow self-assigned this May 31, 2024
@lkiesow lkiesow merged commit 6e61447 into opencast:main May 31, 2024
4 checks passed
@ziegenberg ziegenberg deleted the replace-deprecated-i18next-xhr-backend branch June 4, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lkiesow lkiesow

Labels
type:dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziegenberg @lkiesow